Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add improvements of device_automation from frontend PR 3514 #26295

Merged
merged 3 commits into from
Sep 2, 2019
Merged

Add improvements of device_automation from frontend PR 3514 #26295

merged 3 commits into from
Sep 2, 2019

Conversation

emontnemery
Copy link
Contributor

Description:

Add improvements from frontend PR home-assistant/frontend#3514

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@emontnemery emontnemery requested a review from a team as a code owner August 30, 2019 14:20
@emontnemery emontnemery mentioned this pull request Aug 30, 2019
Merged
@emontnemery emontnemery changed the title Add improvements from frontend PR 3514 Add improvements of device_automation from frontend PR 3514 Aug 30, 2019
balloob
balloob reviewed Aug 30, 2019
View reviewed changes
homeassistant/components/light/strings.json Outdated
{
"device_automation": {
"trigger_type": {
"turn_on": "{entity_id} turned on",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to {name}

@emontnemery emontnemery force-pushed the device_automation_tweaks branch from 0b16efd to 4616322 Compare August 30, 2019 14:59
balloob
balloob approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's not merge this until we're sure the frontend won't require more changes.

@balloob balloob merged commit 3aa2729 into home-assistant:dev Sep 2, 2019
@lock lock bot locked and limited conversation to collaborators Sep 3, 2019
@emontnemery emontnemery deleted the device_automation_tweaks branch September 6, 2019 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: automation integration: device_automation integration: light small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @balloob @homeassistant