Fix eco preset for Wink Air Conditioner

[cameronrmorris]

Description:

• Add preset support for device
• Provide mappings between preset changes

Wink App:

After changes

HA card:

HA card details:

Related issue (if applicable): fixes #25762

Pull request with documentation for home-assistant.io (if applicable):

Example entry for configuration.yaml (if applicable):

wink:

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[Santobert]

Since I am not a maintainer of this project, I can only give some hints:

• As already mentioned here HVAC_MODE_AUTO is reserved for learned behavior, AI or any other related mechanism. I would suggest using HVAC_MODE_HEAT_COOL instead of HVAC_MODE_AUTO if no AI is included.
• I don't know how Wink handles eco mode. If eco is another mode besides auto, I would suggest to make it a preset. If eco is the only mode that controls the temperature based on user input, it might be okay to map winks eco to HA's HVAC_MODE_HEAT_COOL.

As I said, I am not a maintainer, but I had the same issues with the integration of the zwave climate.

As mentioned in the documentation, they have split operation_mode into hvac_mode and preset_mode. Hvac_modes are a small subset of operation_modes such as heat, cool and heat/cool. All other modes (boost, eco, away, etc.) are now preset_modes.
https://www.home-assistant.io/components/climate/

[cameronrmorris]

Thanks for that!

I believe I now understand the expected integration. The Wink AC "auto_eco" state should be only reachable if HA is in a "HVAC_MODE_COOL" and "PRESET_ECO" state.

The user would do that by setting 'PRESET_ECO'.

Internally, the operation mode(HVAC_MODE_COOL) and preset(PRESET_ECO) and the wink api would receive a mode of "auto_eco".

So effectively, we get a state transition like this(apologies it's verbose):

[Santobert]

Looks good. But some transactions are not possible because you won't get a signal when the user selects sth. that is already selected. So when auto_eco is active, it is not possible to select HVAC_MODE_COOL, which is already active, to go to cool_only. PRESET_NONE is still possible in that situation.

[balloob]

I think that we should keep returning AUTO here. We could optionally check if AUTO is supported first (it's part of hvac_modes)

[cameronrmorris]

The idea here was to have the "auto_eco" wink mode displayed as "Cool - Eco". If this returns AUTO it will be displayed as "Auto - Eco". Which style is preferred?

I think the AUTO(in hvac_modes) state is causing confusion because the state map is currently shared with the Wink Thermostat which has a real auto mode(e.g. automatic temperate changes). Maybe it's better to separate the state maps for both the Thermostat and Air conditioner for clarity?

[balloob]

Oh, this is my bad. I did not realize that this was changing code inside the AC entity. This is ok .