Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfxtrx sensor #2563

Merged
merged 3 commits into from
Jul 20, 2016
Merged

Rfxtrx sensor #2563

merged 3 commits into from
Jul 20, 2016

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Jul 19, 2016

Description:
Allow fire event when receiving signal from a Rfxtrx sensor

Related issue (if applicable): fixes some problems mentioned here #2290

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#660

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices, web services, or a:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob
Copy link
Member

balloob commented Jul 20, 2016

Looks good! 🐬

@balloob balloob merged commit d64dae8 into dev Jul 20, 2016
@balloob balloob deleted the rfxtrx_sensor branch July 20, 2016 02:15
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants