Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch uncaught Alexa error #24785

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Catch uncaught Alexa error #24785

merged 1 commit into from
Jun 27, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 27, 2019

Description:

Fix uncaught exception and instead returns correct error.

Related issue (if applicable): fixes #24784

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link

ghost commented Jun 27, 2019

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (cloud) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@balloob balloob merged commit c87d6e4 into dev Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the catch-uncaught-alexa-error branch June 27, 2019 03:24
balloob added a commit that referenced this pull request Jun 27, 2019
@balloob balloob mentioned this pull request Jun 27, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poor error message for Alexa Enable State Reporting
2 participants