Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RainMachine device classes where appropriate #24682

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Add RainMachine device classes where appropriate #24682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add RainMachine device classes where appropriate
  • Loading branch information
@bachya
bachya committed Jun 21, 2019
commit 44104729b3be1ff162d76c6669d36ee1e9b838f0
15 changes: 11 additions & 4 deletions homeassistant/components/rainmachine/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,15 @@

SENSORS = {
TYPE_FLOW_SENSOR_CLICK_M3: (
'Flow Sensor Clicks', 'mdi:water-pump', 'clicks/m^3'),
'Flow Sensor Clicks', 'mdi:water-pump', 'clicks/m^3', None),
TYPE_FLOW_SENSOR_CONSUMED_LITERS: (
'Flow Sensor Consumed Liters', 'mdi:water-pump', 'liter'),
'Flow Sensor Consumed Liters', 'mdi:water-pump', 'liter', None),
TYPE_FLOW_SENSOR_START_INDEX: (
'Flow Sensor Start Index', 'mdi:water-pump', None),
TYPE_FLOW_SENSOR_WATERING_CLICKS: (
'Flow Sensor Clicks', 'mdi:water-pump', 'clicks'),
TYPE_FREEZE_TEMP: ('Freeze Protect Temperature', 'mdi:thermometer', '°C'),
'Flow Sensor Clicks', 'mdi:water-pump', 'clicks', None),
TYPE_FREEZE_TEMP: (
'Freeze Protect Temperature', 'mdi:thermometer', '°C', 'temperature'),
}

BINARY_SENSOR_SCHEMA = vol.Schema({
Expand Down Expand Up @@ -371,10 +372,16 @@ class RainMachineEntity(Entity):
def __init__(self, rainmachine):
"""Initialize."""
self._attrs = {ATTR_ATTRIBUTION: DEFAULT_ATTRIBUTION}
self._device_class = None
self._dispatcher_handlers = []
self._name = None
self.rainmachine = rainmachine

@property
def device_class(self):
"""Return the device class."""
return self._device_class

@property
def device_info(self):
"""Return device registry information for this entity."""
Expand Down
9 changes: 6 additions & 3 deletions homeassistant/components/rainmachine/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,23 @@ async def async_setup_entry(hass, entry, async_add_entities):

sensors = []
for sensor_type in rainmachine.sensor_conditions:
name, icon, unit = SENSORS[sensor_type]
name, icon, unit, device_class = SENSORS[sensor_type]
sensors.append(
RainMachineSensor(rainmachine, sensor_type, name, icon, unit))
RainMachineSensor(
rainmachine, sensor_type, name, icon, unit, device_class))

async_add_entities(sensors, True)


class RainMachineSensor(RainMachineEntity):
"""A sensor implementation for raincloud device."""

def __init__(self, rainmachine, sensor_type, name, icon, unit):
def __init__(
self, rainmachine, sensor_type, name, icon, unit, device_class):
"""Initialize."""
super().__init__(rainmachine)

self._device_class = device_class
self._icon = icon
self._name = name
self._sensor_type = sensor_type
Expand Down