Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device class support for Ambient PWS sensors #24677

Merged
merged 1 commit into from
Jun 21, 2019

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jun 21, 2019

Description:

Previously, the ambient component only used device classes for binary sensors. This PR adds device class support for appropriate sensors, as well.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

ambient_station:
  api_key: !secret ambient_api_key
  app_key: !secret ambient_app_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@bachya bachya self-assigned this Jun 21, 2019
@bachya bachya merged commit 3da3612 into home-assistant:dev Jun 21, 2019
@bachya bachya deleted the ambient-device-classes branch June 21, 2019 16:28
@balloob balloob mentioned this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants