Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aml_thermal label #24665

Merged
merged 1 commit into from
Jun 22, 2019
Merged

Add aml_thermal label #24665

merged 1 commit into from
Jun 22, 2019

Conversation

jmw6773
Copy link
Contributor

@jmw6773 jmw6773 commented Jun 21, 2019

Added label for the CPU Temperature for AmLogic ARM chips.

Breaking Change:

Description:

CPU Temperature isn't reported for AML chips. Adding the 'aml_thermal' label for the temperature sensor fixes the issue (Tested on S812 and S905 devices.)

Example entry for configuration.yaml (if applicable):

  - platform: glances
    host: localhost
    resources:
      - cpu_temp

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Added label for the CPU Temperature for AmLogic ARM chips.
@jmw6773 jmw6773 requested a review from fabaff as a code owner June 21, 2019 04:57
@homeassistant
Copy link
Contributor

Hi @jmw6773,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost assigned fabaff Jun 21, 2019
@ghost
Copy link

ghost commented Jun 21, 2019

Hey there @fabaff, mind taking a look at this pull request as its been labeled with a integration (glances) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

@fabaff fabaff merged commit d25214b into home-assistant:dev Jun 22, 2019
@balloob balloob mentioned this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants