Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

braviatv, nmap_tracker: use getmac for getting MAC addresses #24628

Merged
merged 2 commits into from
Jun 20, 2019
Merged

braviatv, nmap_tracker: use getmac for getting MAC addresses #24628

merged 2 commits into from
Jun 20, 2019

Conversation

scop
Copy link
Member

@scop scop commented Jun 19, 2019

Description:

See discussion in #24601

Related issue (if applicable): #24601

Checklist:

  • The code change is tested and works locally. nmap tracker only
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost
Copy link

ghost commented Jun 19, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (braviatv) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two small comments.

@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@4e066f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #24628   +/-   ##
======================================
  Coverage       ?    94.1%           
======================================
  Files          ?      524           
  Lines          ?    40382           
  Branches       ?        0           
======================================
  Hits           ?    38000           
  Misses         ?     2382           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e066f4...d424edd. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (dev@4e066f4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #24628   +/-   ##
======================================
  Coverage       ?    94.1%           
======================================
  Files          ?      524           
  Lines          ?    40382           
  Branches       ?        0           
======================================
  Hits           ?    38000           
  Misses         ?     2382           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e066f4...d424edd. Read the comment docs.

@scop scop merged commit f1cbb2a into home-assistant:dev Jun 20, 2019
@scop scop deleted the getmac branch June 20, 2019 20:35
@balloob balloob mentioned this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants