-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
braviatv, nmap_tracker: use getmac for getting MAC addresses #24628
Conversation
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Two small comments.
Codecov Report
@@ Coverage Diff @@
## dev #24628 +/- ##
======================================
Coverage ? 94.1%
======================================
Files ? 524
Lines ? 40382
Branches ? 0
======================================
Hits ? 38000
Misses ? 2382
Partials ? 0 Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #24628 +/- ##
======================================
Coverage ? 94.1%
======================================
Files ? 524
Lines ? 40382
Branches ? 0
======================================
Hits ? 38000
Misses ? 2382
Partials ? 0 Continue to review full report at Codecov.
|
Description:
See discussion in #24601
Related issue (if applicable): #24601
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: