Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate geniushub to new climate schema #24191

Merged
merged 67 commits into from
Jul 4, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
a814484
Update one
pvizeli May 14, 2019
f86cd6a
Fix model climate v2
pvizeli May 15, 2019
3cb4ff8
Cleanup p4
pvizeli May 16, 2019
d16dff9
Add comfort hold mode
pvizeli May 16, 2019
ba3d424
Fix old code
pvizeli May 16, 2019
9be6768
Update homeassistant/components/climate/__init__.py
pvizeli May 16, 2019
5c5fc38
Update homeassistant/components/climate/const.py
pvizeli May 16, 2019
deb86e5
First renaming
pvizeli May 16, 2019
1e6e2ec
Rename operation to hvac for paulus
pvizeli May 16, 2019
17ce0ae
Rename hold mode to preset mode
pvizeli May 16, 2019
dbb8aa4
Cleanup & update comments
pvizeli May 17, 2019
f6d77d6
Remove on/off
pvizeli May 17, 2019
0d07e22
Fix supported feature count
pvizeli May 17, 2019
af95d75
Update services
pvizeli May 17, 2019
e0097c1
Update demo
pvizeli May 17, 2019
cfecfbd
Fix tests & use current_hvac
pvizeli May 20, 2019
d2bcee3
Update comment
pvizeli May 20, 2019
72fa8b9
Fix tests & add typing
pvizeli May 20, 2019
3d1917b
Add more typing
pvizeli May 20, 2019
e921252
Update modes
pvizeli May 20, 2019
151a6c4
Fix tests
pvizeli May 20, 2019
fb85e9a
Cleanup low/high with range
pvizeli May 20, 2019
d964eab
Update homematic part 1
pvizeli May 20, 2019
1fdf810
Finish homematic
pvizeli May 20, 2019
e52a1bc
Fix lint
pvizeli May 21, 2019
9ccd1e8
fix hm mapping
pvizeli May 21, 2019
41376cd
Support simple devices
pvizeli May 21, 2019
8a091d5
convert lcn
pvizeli May 22, 2019
1e8d74f
migrate oem
pvizeli May 22, 2019
fe7794a
Fix xs1
pvizeli May 22, 2019
32efc21
update hive
pvizeli May 22, 2019
e241f56
update mil
pvizeli May 22, 2019
0d20645
Update toon
pvizeli May 22, 2019
772b07e
migrate deconz
pvizeli May 22, 2019
88bcce1
cleanup
pvizeli May 22, 2019
1083cd7
update tesla
pvizeli May 22, 2019
110ca3d
Fix lint
pvizeli May 23, 2019
dfe8902
Fix vera
pvizeli May 23, 2019
b92ec04
Migrate zwave
pvizeli May 23, 2019
84c98a0
Migrate velbus
pvizeli May 23, 2019
9af2fd1
Cleanup humity feature
pvizeli May 23, 2019
a8d538b
Cleanup
pvizeli May 24, 2019
4b1495f
Migrate wink
pvizeli May 24, 2019
6aacd16
migrate dyson
pvizeli May 27, 2019
9c546b7
Fix current hvac
pvizeli May 27, 2019
2bdfa0b
Renaming
pvizeli May 27, 2019
65d183a
Fix lint
pvizeli May 27, 2019
eb049b2
Migrate tfiac
pvizeli May 27, 2019
abfd323
migrate tado
pvizeli May 29, 2019
fec87c5
delinted
zxdavb May 29, 2019
64929c8
use latest client
zxdavb May 29, 2019
1b72af5
clean up mappings
zxdavb May 29, 2019
798350b
add duration to set_temperature
zxdavb May 30, 2019
110d80f
delinted
zxdavb May 29, 2019
22de487
clean up mappings
zxdavb May 29, 2019
fe38786
add duration to set_temperature
zxdavb May 30, 2019
97e6b61
manual rebase
zxdavb Jul 2, 2019
7913210
tweak
zxdavb Jul 2, 2019
2f6bfb9
fix regression
zxdavb Jul 2, 2019
f3210eb
small fix
zxdavb Jul 2, 2019
3f45d98
fix rebase mixup
zxdavb Jul 2, 2019
fa0c916
address comments
zxdavb Jul 3, 2019
64e884c
finish refactor
zxdavb Jul 3, 2019
3c499b8
fix regression
zxdavb Jul 3, 2019
dbd20d7
tweak type hints
zxdavb Jul 3, 2019
c609600
delint
zxdavb Jul 3, 2019
f0f1b9e
manual rebase
zxdavb Jul 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename hold mode to preset mode
  • Loading branch information
pvizeli authored and zxdavb committed Jul 4, 2019
commit 17ce0ae9c74b5d370247a0d3a42a7e5e4edb4fe0
42 changes: 21 additions & 21 deletions homeassistant/components/climate/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@

from .const import (
ATTR_AUX_HEAT, ATTR_CURRENT_HUMIDITY, ATTR_CURRENT_OPERATION,
ATTR_CURRENT_TEMPERATURE, ATTR_FAN_LIST, ATTR_FAN_MODE, ATTR_HOLD_LIST,
ATTR_HOLD_MODE, ATTR_HUMIDITY, ATTR_HVAC_MODE, ATTR_HVAC_MODES,
ATTR_MAX_HUMIDITY, ATTR_MAX_TEMP, ATTR_MIN_HUMIDITY, ATTR_MIN_TEMP,
ATTR_CURRENT_TEMPERATURE, ATTR_FAN_LIST, ATTR_FAN_MODE, ATTR_HUMIDITY,
ATTR_HVAC_MODE, ATTR_HVAC_MODES, ATTR_MAX_HUMIDITY, ATTR_MAX_TEMP,
ATTR_MIN_HUMIDITY, ATTR_MIN_TEMP, ATTR_PRESET_LIST, ATTR_PRESET_MODE,
ATTR_SWING_LIST, ATTR_SWING_MODE, ATTR_TARGET_TEMP_HIGH,
ATTR_TARGET_TEMP_LOW, ATTR_TARGET_TEMP_STEP, DOMAIN, HVAC_MODES,
SERVICE_SET_AUX_HEAT, SERVICE_SET_FAN_MODE, SERVICE_SET_HOLD_MODE,
SERVICE_SET_AUX_HEAT, SERVICE_SET_FAN_MODE, SERVICE_SET_PRESET_MODE,
SERVICE_SET_HUMIDITY, SERVICE_SET_HVAC_MODE, SERVICE_SET_SWING_MODE,
SERVICE_SET_TEMPERATURE, SUPPORT_AUX_HEAT, SUPPORT_CURRENT_OPERATION,
SUPPORT_FAN_MODE, SUPPORT_HOLD_MODE, SUPPORT_SWING_MODE,
SUPPORT_FAN_MODE, SUPPORT_PRESET_MODE, SUPPORT_SWING_MODE,
SUPPORT_TARGET_HUMIDITY, SUPPORT_TARGET_HUMIDITY_HIGH,
SUPPORT_TARGET_HUMIDITY_LOW, SUPPORT_TARGET_TEMPERATURE_HIGH,
SUPPORT_TARGET_TEMPERATURE_LOW)
Expand Down Expand Up @@ -72,7 +72,7 @@
})
SET_PRESET_MODE_SCHEMA = vol.Schema({
vol.Optional(ATTR_ENTITY_ID): cv.comp_entity_ids,
vol.Required(ATTR_PRESET_MODE): vol.Maybe(cv.string),
vol.Required(ATTR_PRESET_MODE): cv.string,
})
SET_HVAC_MODE_SCHEMA = vol.Schema({
vol.Optional(ATTR_ENTITY_ID): cv.comp_entity_ids,
Expand All @@ -95,8 +95,8 @@ async def async_setup(hass: HomeAssistantType, config: ConfigType) -> bool:
await component.async_setup(config)

component.async_register_entity_service(
SERVICE_SET_HOLD_MODE, SET_HOLD_MODE_SCHEMA,
'async_set_hold_mode'
SERVICE_SET_PRESET_MODE, SET_PRESET_MODE_SCHEMA,
'async_set_preset_mode'
)
component.async_register_entity_service(
SERVICE_SET_AUX_HEAT, SET_AUX_HEAT_SCHEMA,
Expand Down Expand Up @@ -201,10 +201,10 @@ def state_attributes(self) -> Dict[str, Any]:
if supported_features & SUPPORT_CURRENT_OPERATION:
data[ATTR_CURRENT_OPERATION] = self.current_operation

if supported_features & SUPPORT_HOLD_MODE:
data[ATTR_HOLD_MODE] = self.current_hold_mode
if self.hold_list:
data[ATTR_HOLD_LIST] = self.hold_list
if supported_features & SUPPORT_PRESET_MODE:
data[ATTR_PRESET_MODE] = self.preset_mode
if self.preset_list:
data[ATTR_PRESET_LIST] = self.preset_list

if supported_features & SUPPORT_SWING_MODE:
data[ATTR_SWING_MODE] = self.current_swing_mode
Expand Down Expand Up @@ -270,13 +270,13 @@ def target_temperature_high(self) -> Optional[float]:
raise NotImplementedError

@property
def current_hold_mode(self):
"""Return the current hold mode, e.g., home, away, temp."""
def preset_mode(self):
"""Return the current preset mode, e.g., home, away, temp."""
return None

@property
def hold_list(self):
"""Return a list of available hold modes."""
def preset_list(self):
"""Return a list of available preset modes."""
return None

@property
Expand Down Expand Up @@ -383,16 +383,16 @@ def async_set_swing_mode(self, swing_mode: str) -> Awaitable[None]:
"""
return self.hass.async_add_job(self.set_swing_mode, swing_mode)

def set_hold_mode(self, hold_mode):
"""Set new target hold mode."""
def set_preset_mode(self, preset_mode):
"""Set new preset mode."""
raise NotImplementedError()

def async_set_hold_mode(self, hold_mode):
"""Set new target hold mode.
def async_set_preset_mode(self, preset_mode):
"""Set new preset mode.

This method must be run in the event loop and returns a coroutine.
"""
return self.hass.async_add_job(self.set_hold_mode, hold_mode)
return self.hass.async_add_job(self.set_preset_mode, preset_mode)

def turn_aux_heat_on(self):
"""Turn auxiliary heater on."""
Expand Down
14 changes: 7 additions & 7 deletions homeassistant/components/climate/const.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,16 @@


# Device is running an energy-saving mode
HOLD_MODE_ECO = 'eco'
PRESET_ECO = 'eco'

# Device is on away mode
HOLD_MODE_AWAY = 'away'
PRESET_AWAY = 'away'

# Device turn all valve full up
HOLD_MODE_BOOST = 'boost'
PRESET_BOOST = 'boost'

# Device have a comfort mode
HOLD_MODE_COMFORT = 'comfort'
PRESET_COMFORT = 'comfort'


# This are support current states of HVAC
Expand All @@ -61,8 +61,8 @@
ATTR_CURRENT_OPERATION = 'current_operation'
ATTR_FAN_LIST = 'fan_list'
ATTR_FAN_MODE = 'fan_mode'
ATTR_HOLD_MODE = 'hold_mode'
ATTR_HOLD_LIST = 'hold_list'
ATTR_PRESET_MODE = 'preset_mode'
ATTR_PRESET_LIST = 'preset_list'
ATTR_HUMIDITY = 'humidity'
ATTR_MAX_HUMIDITY = 'max_humidity'
ATTR_MIN_HUMIDITY = 'min_humidity'
Expand Down Expand Up @@ -98,7 +98,7 @@
SUPPORT_TARGET_HUMIDITY_HIGH = 16
SUPPORT_TARGET_HUMIDITY_LOW = 32
SUPPORT_FAN_MODE = 64
SUPPORT_HOLD_MODE = 128
SUPPORT_PRESET_MODE = 128
SUPPORT_SWING_MODE = 256
SUPPORT_AUX_HEAT = 512
SUPPORT_ON_OFF = 1024
Expand Down