Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zestimate: Fix for issue #23739. Added unique_id property #23769

Merged
merged 1 commit into from
May 10, 2019
Merged

Zestimate: Fix for issue #23739. Added unique_id property #23769

merged 1 commit into from
May 10, 2019

Conversation

dreed47
Copy link
Contributor

@dreed47 dreed47 commented May 9, 2019

Description:

Added unique_id property so that entities will always get mapped to the same
property ZPID code.

Related issue (if applicable): fixes #
fixes #23739

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

that entities will always get mapped to the same
property ZPID code.
@andrewsayre andrewsayre added this to the 0.93 milestone May 9, 2019
@andrewsayre
Copy link
Member

Can merge once build passes.

@balloob balloob merged commit 2814459 into home-assistant:dev May 10, 2019
pvizeli pushed a commit that referenced this pull request May 10, 2019
that entities will always get mapped to the same
property ZPID code.
@balloob balloob mentioned this pull request May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zestimate: when using multiple zpid's updates can refresh the wrong entity
5 participants