Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend to the example config #2367

Merged
merged 1 commit into from
Jun 25, 2016
Merged

Add frontend to the example config #2367

merged 1 commit into from
Jun 25, 2016

Conversation

Danielhiversen
Copy link
Member

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#

Example entry for configuration.yaml (if applicable):

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob
Copy link
Member

balloob commented Jun 25, 2016

I wonder if we should still keep this example config around. It doesn't add much value as it is not maintained. The examples on our website are a lot better.

Anyway, frontend should be there for as long as it is around 🐬

@balloob balloob merged commit 7a8c5a0 into dev Jun 25, 2016
@balloob balloob deleted the Danielhiversen-patch-1 branch June 25, 2016 04:40
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants