Migrate tests to pytest #23544
Merged
Migrate tests to pytest #23544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
commented
Apr 29, 2019
| def setUp(self): | ||
| """Set up the tests.""" | ||
| self.hass = get_test_home_assistant() | ||
| self.hass.config.unit_system = METRIC_SYSTEM |
| """Run when tests are started.""" | ||
| self.hass = get_test_home_assistant() | ||
| run_coroutine_threadsafe(async_setup_component( | ||
| self.hass, 'homeassistant', {}), self.hass.loop).result() |
There was a problem hiding this comment.
Not anymore after we refactored scene. Used to be that this would set up homeassistant.turn_on
| def test_as_local_with_local_object(): | ||
| """Test local with local object.""" | ||
| now = dt_util.now() | ||
| assert now == now |
tests/scripts/test_check_config.py
Outdated
| try: | ||
| asyncio.get_event_loop() | ||
| except RuntimeError: | ||
| asyncio.set_event_loop(asyncio.new_event_loop()) |
There was a problem hiding this comment.
Why is this needed?
There was a problem hiding this comment.
Changed to use the loop fixture from aiohttp.pytest_plugin instead.
balloob
approved these changes
Apr 30, 2019
|
Looked at some of the CI results, and saw between 40s-1m30s speed bump! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Migrate some tests to pytest
Also some minor cleanup of tests
Checklist:
tox. Your PR cannot be merged unless tests pass