Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyhs100 requirement for tplink integration #23065

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

rytilahti
Copy link
Member

Description:

New upstream release with some minor fixes.

Related issue (if applicable): fixes #20994

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned rytilahti Apr 13, 2019
@ghost ghost added the in progress label Apr 13, 2019
@fabaff fabaff changed the title bump pyhs100 requirement for tplink integration Bump pyhs100 requirement for tplink integration Apr 13, 2019
@ghost ghost assigned amelchio Apr 15, 2019
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #23065 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23065      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +<.01%     
==========================================
  Files         451      451              
  Lines       36759    36759              
==========================================
+ Hits        34531    34532       +1     
+ Misses       2228     2227       -1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 95.74% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a473a...596247d. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #23065 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23065      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +<.01%     
==========================================
  Files         451      451              
  Lines       36759    36759              
==========================================
+ Hits        34531    34532       +1     
+ Misses       2228     2227       -1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 95.74% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a473a...596247d. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #23065 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23065      +/-   ##
==========================================
+ Coverage   93.93%   93.94%   +<.01%     
==========================================
  Files         451      451              
  Lines       36759    36759              
==========================================
+ Hits        34531    34532       +1     
+ Misses       2228     2227       -1
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 95.74% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a473a...596247d. Read the comment docs.

@rytilahti rytilahti merged commit f48eb91 into home-assistant:dev Apr 16, 2019
@ghost ghost removed the in progress label Apr 16, 2019
@rytilahti rytilahti deleted the bump_pyhs100 branch April 16, 2019 00:29
@rytilahti
Copy link
Member Author

Thanks @amelchio for fixing the missing bump for requirements_test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tp-link fails on KL130 bulbs due to missing color temperature information
3 participants