Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-slugify to 3.0.2 #22997

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Upgrade python-slugify to 3.0.2 #22997

merged 1 commit into from
Apr 13, 2019

Conversation

BKPepe
Copy link
Contributor

@BKPepe BKPepe commented Apr 11, 2019

Description:

Devs from python-slugify these days released a few versions recently. The latest version is 3.0.2 from 31st March 2019. HA has a requirement for version 1.2.6 from 2nd September 2018.

Changelog: https://github.com/un33k/python-slugify/blob/master/CHANGELOG.md

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@BKPepe BKPepe requested a review from a team as a code owner April 11, 2019 14:29
@ghost ghost added the in progress label Apr 11, 2019
@homeassistant
Copy link
Contributor

Hi @BKPepe,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@fabaff fabaff changed the title python-slugify: use version 3.0.2 and newer Upgrade python-slugify to 3.0.2 Apr 12, 2019
@fabaff fabaff merged commit 18cf827 into home-assistant:dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@BKPepe BKPepe deleted the slugify branch April 15, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants