Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for optional values in the update_location webhook call #22817

Merged
merged 2 commits into from
Apr 7, 2019

Conversation

robbiet480
Copy link
Member

@robbiet480 robbiet480 commented Apr 7, 2019

Optional values weren't correctly being added to the device_tracker.see payload causing schema errors, originally detected from location_name.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@ghost ghost assigned robbiet480 Apr 7, 2019
@ghost ghost added the in progress label Apr 7, 2019
@robbiet480 robbiet480 added this to the 0.91.2 milestone Apr 7, 2019
@awarecan awarecan merged commit 6492809 into dev Apr 7, 2019
@ghost ghost removed the in progress label Apr 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the mobile_app-location-name-fix branch April 7, 2019 08:17
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
…istant#22817)

* Fix for optional values in the update_location webhook call

* Square brackets instead of .get
pvizeli pushed a commit that referenced this pull request Apr 8, 2019
* Fix for optional values in the update_location webhook call

* Square brackets instead of .get
@pvizeli pvizeli mentioned this pull request Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants