-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate requirements_* from manifests #22718
Conversation
1000 points to @rohankapoorcom for taking the initiative on this without prompting! |
Codecov Report
@@ Coverage Diff @@
## dev #22718 +/- ##
==========================================
- Coverage 93.83% 93.83% -0.01%
==========================================
Files 449 448 -1
Lines 36584 36524 -60
==========================================
- Hits 34330 34271 -59
+ Misses 2254 2253 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do following in same PR
- Remove all REQUIREMENTS from .py code
- Change Pull Request template
- Change dev doc (in dev doc repo of course, but link to here)
Reading #22700, I got the feeling that each of those were intended to be separate tasks. If you think they shouldn't be, I'm happy to make the changes. |
I suggest we make them new tasks. |
Your call. But the elif block need remove, we have manifest validator is running on CI to ensure all components has to have manifest.json |
It's still needed for scripts/auth. I'm breaking them out into different methods per @balloob's above comment: #22718 (comment) |
Changes pushed up. |
I just merged a new integration in, #22684. Please rebase. |
I'll look at ordering and will rebase in the evening. Just headed into the office. |
6e6b8a9
to
f42df1c
Compare
I rebased and fixed the error. EDIT: order is done. |
Thanks for the assist @awarecan! |
Co-Authored-By: rohankapoorcom <rohan@rohankapoor.com>
97f47dd
to
8f06cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we aren't good, we'll fix it in post, lets get this show on the road
Description:
Generate requirements_* from manifests (if present). If not, fallback to the current approach of reading
REQUIREMENTS
from the module attribute. I disabled exploring the children of thehomeassistant.components.*
packages since that will just add a dependency (from the manifest) due to each of the python files in the package. Just having one for the top level package should be sufficient.Related issue (if applicable): relates to #22700
Checklist:
tox
. Your PR cannot be merged unless tests pass