Allow users to set encoding of mikrotik connection #22715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: mikrotik
small-pr
ghost
assigned 
MartinHjelmare
changed the title
MartinHjelmare
approved these changes
Apr 4, 2019
|
Off topic: Why is there 7 checks for codeowners mention? |
New |
Codecov Report
@@ Coverage Diff @@
## dev #22715 +/- ##
=======================================
Coverage 93.83% 93.83%
=======================================
Files 449 449
Lines 36568 36568
=======================================
Hits 34315 34315
Misses 2253 2253Continue to review full report at Codecov.
|
unibeck
pushed a commit
to unibeck/home-assistant
that referenced
this pull request
Apr 7, 2019
) ## Description: Mikrotik does some stupid stuff with character encoding that can screw up the DHCP responses. See home-assistant#15257 for more detail. **Related issue (if applicable):** fixes home-assistant#15257 ## Checklist: - [x] The code change is tested and works locally. - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass** - [x] There is no commented out code in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Mikrotik does some stupid stuff with character encoding that can screw up the DHCP responses. See #15257 for more detail.
Related issue (if applicable): fixes #15257
Checklist:
tox. Your PR cannot be merged unless tests pass