Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all config deprecations invalidated in 0.91 #22704

Merged
merged 2 commits into from
Apr 4, 2019

Conversation

rohankapoorcom
Copy link
Member

@rohankapoorcom rohankapoorcom commented Apr 4, 2019

Description:

In release 0.88, we deprecated the following items:

Per their configuration at deprecation time, users using the old configuration would have had warning logs until 0.91 when the configuration would be invalidated. Since we release 0.91 today, we are now able to clean up and remove these from the code base.

This is not a breaking change because the deprecation config validator would have already broken the configurations with the release of 0.91 and we announced the breaking change as part of 0.88.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #22704 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #22704   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files         449      449           
  Lines       36568    36568           
=======================================
  Hits        34314    34314           
  Misses       2254     2254
Impacted Files Coverage Δ
homeassistant/components/darksky/sensor.py 97.72% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aac49d...9142d44. Read the comment docs.

@rohankapoorcom rohankapoorcom merged commit afac099 into dev Apr 4, 2019
@ghost ghost removed the in progress label Apr 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the remove-invalid-deprecations branch April 4, 2019 06:32
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
)

* Remove all config deprecations invalidated in 0.91

* Fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants