Wink sensors #22
Merged
Wink sensors #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: Exclude external libraries from code coverage Bug fixes for Wink Better positioning of dialogs Added error handling in frontend debug forms Integrate add worker to bootstrap.setup_component Conditionally show widgets on light more info Rename the edit state button in more info to debug Expect devices to have no name
Refactor wink API fetching into a generic 'get_devices' function.
Hook up to scan sensor_pod_id's from Wink and report their status.
|
Added you as a collaborator on the project. Trying out something I read. |
|
Bah, now you called me out on my original one :) That said, working on the rest of the pylint/flake8/etc requirements. But, working on a rpi for this project, will take a few. |
|
Also, to be fair, I did open the original one as a discussion point for the sensor base. :) |
|
Oh, you didn't want it to be merged yet, it seemed like mvp was done, no? |
|
MVP was enough, its ok. It just happened that I was working on requirements.txt in the background gated by rpi clock cycles. :) |
|
Self-judgement, not project-judgement. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing on dev due to timer changes.
Again, ideally wink will give us push, polling doors even on 3s, sucks.