Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZHA fixes #21592

Merged
merged 4 commits into from
Mar 2, 2019
Merged

ZHA fixes #21592

merged 4 commits into from
Mar 2, 2019

Conversation

dmulcahey
Copy link
Contributor

@dmulcahey dmulcahey commented Mar 2, 2019 •
edited
Loading

This PR:

  • prevents attr reporting on cluster 0x1000 (it is the light link cluster and we shouldn't do it)
  • uses a semaphore to prevent flooding the network during configuration and initialization
  • updates switch to use the same mechanism to set state after interaction as light
  • adds a 60 minute lifeline pulse to lights to prevent them from going unavailable

@dmulcahey dmulcahey requested review from balloob and Adminiuga March 2, 2019 13:42
@ghost ghost assigned dmulcahey Mar 2, 2019
@ghost ghost added the in progress label Mar 2, 2019
@dmulcahey
Copy link
Contributor Author

@balloob this should fix the light link traceback from yesterday when you paired the tradfri bulb.

@dmulcahey dmulcahey mentioned this pull request Mar 2, 2019
Closed
Adminiuga
Adminiuga approved these changes Mar 2, 2019
View reviewed changes
homeassistant/components/zha/light.py Outdated Show resolved Hide resolved
@dmulcahey dmulcahey changed the title ZHA fixes WIP - ZHA fixes Mar 2, 2019
@dmulcahey dmulcahey changed the title WIP - ZHA fixes ZHA fixes Mar 2, 2019
Adminiuga
Adminiuga approved these changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged when the build passes

@Adminiuga Adminiuga merged commit 45316f6 into home-assistant:dev Mar 2, 2019
@ghost ghost removed the in progress label Mar 2, 2019
@balloob balloob mentioned this pull request Mar 20, 2019
Merged
@dmulcahey dmulcahey deleted the dm/zha-zll-fixes branch May 8, 2019 10:58
@kbickar kbickar mentioned this pull request Feb 14, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adminiuga Adminiuga Adminiuga approved these changes

@balloob balloob Awaiting requested review from balloob

Assignees

@dmulcahey dmulcahey

Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmulcahey @Adminiuga @homeassistant