Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Word the tplink deprecation warning more strongly #21586

Merged
merged 1 commit into from
Mar 2, 2019
Merged

Word the tplink deprecation warning more strongly #21586

merged 1 commit into from
Mar 2, 2019

Conversation

amelchio
Copy link
Contributor

@amelchio amelchio commented Mar 2, 2019

Description:

The current wording confused me when testing the beta.

A deprecation usually means that the feature still works but is on its way out. When it no longer works, it is obsolete ... but I picked a more friendly wording here :)

Example entry for configuration.yaml (if applicable):

switch:
  - platform: tplink
    host: 10.30.2.21

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

@amelchio amelchio added this to the 0.89.0 milestone Mar 2, 2019
@amelchio amelchio requested a review from rytilahti as a code owner March 2, 2019 10:31
@ghost ghost assigned amelchio Mar 2, 2019
@ghost ghost added the in progress label Mar 2, 2019
@Danielhiversen Danielhiversen merged commit 5eab869 into home-assistant:dev Mar 2, 2019
@ghost ghost removed the in progress label Mar 2, 2019
balloob pushed a commit that referenced this pull request Mar 5, 2019
@amelchio @balloob
Word the tplink deprecation warning more strongly (#21586)
e6debe0
@balloob balloob mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danielhiversen Danielhiversen Danielhiversen approved these changes

@fabaff fabaff fabaff approved these changes

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

Assignees

@amelchio amelchio

Labels
cherry-picked cla-signed integration: tplink small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.89.0
Development

Successfully merging this pull request may close these issues.
5 participants
@amelchio @fabaff @Danielhiversen @balloob @homeassistant