Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new pyvesyncv_v2 library and vesync switch support #21449

Merged
merged 4 commits into from
Mar 2, 2019
Merged

Conversation

webdjoe
Copy link
Contributor

@webdjoe webdjoe commented Feb 26, 2019

Description:

Although the guidelines say to not make trivial edits, I overhauled the older vesync library to support the new outlets and wifi wall switches. I am just updating the pip package used for the vesync switch component. I originally tried to submit a PR for the original vesync library to streamline the changes without impacting HA but the owner hasn't responded in several months. I created a new pip package 'pyvesync_v2' with the same functionality as the original vesync so it would integrate with minimal changes to the component.

**Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8746 -

Example entry for configuration.yaml (if applicable):

{Same as original vesync switch component)

switch:
  - platform: vesync
     username: 
     password:

Checklist:

  • [X ] The code change is tested and works locally.
  • [X ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ X] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [NA] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • [NA] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [NA] New files were added to .coveragerc.

If the code does not interact with devices:

  • [NA] Tests have been added to verify that the new code works.

Update required version for vesync outlets and switches.  Eliminate API call for energy usage for wall switches that do not have that feature
@homeassistant homeassistant added platform: switch.vesync small-pr PRs with less than 30 lines. labels Feb 26, 2019
@homeassistant
Copy link
Contributor

Hi @webdjoe,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Feb 26, 2019
@webdjoe webdjoe changed the title Update for new pyvesynv_v2 library and vesync switch support Update for new pyvesyncv_v2 library and vesync switch support Feb 26, 2019
@Danielhiversen Danielhiversen merged commit 61e4a6b into home-assistant:dev Mar 2, 2019
@ghost ghost removed the in progress label Mar 2, 2019
@balloob balloob mentioned this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants