Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in google travel time #2134

Merged
merged 1 commit into from
May 26, 2016
Merged

bug in google travel time #2134

merged 1 commit into from
May 26, 2016

Conversation

Danielhiversen
Copy link
Member

Description:
Fixes a bug in google travel time, when no options are sat.

16-05-22 19:31:31 ERROR (MainThread) [homeassistant.components.sensor] Error while setting up platform google_travel_time
Traceback (most recent call last):
  File "/mnt/dokumneter/privat/home-assistant/homeassistant/helpers/entity_component.py", line 109, in _setup_platform
    discovery_info)
  File "/mnt/dokumneter/privat/home-assistant/homeassistant/components/sensor/google_travel_time.py", line 99, in setup_platform
    titled_mode = options.get(CONF_MODE).title()
AttributeError: 'NoneType' object has no attribute 'title'

Checklist:

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@balloob
Copy link
Member

balloob commented May 25, 2016

Only see this one right now. Is still relevant with the recent fixes that went out ?

CC @robbiet480

@Danielhiversen
Copy link
Member Author

Danielhiversen commented May 26, 2016

I do not think this is fixed with the latest fixes

@balloob
Copy link
Member

balloob commented May 26, 2016

Alrighty 🐬

@balloob
Copy link
Member

balloob commented May 26, 2016

These are the kind of bugs that are totally fine to merge yourself btw!

@balloob balloob merged commit 71452c1 into dev May 26, 2016
@balloob balloob deleted the google_travel_bug branch May 26, 2016 12:52
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants