Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get_age in util/dt #2067

Merged
merged 1 commit into from
May 14, 2016
Merged

Refactor get_age in util/dt #2067

merged 1 commit into from
May 14, 2016

Conversation

Danielhiversen
Copy link
Member

Description:
Refactor of util/dt.py

Checklist:
If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

@robbiet480
Copy link
Member

👍 👍 👍 👍 👍 👍 @Danielhiversen. Gonna merge this because tests passed. Coveralls sometimes has issues like the one above where coverage increased but it failed still.

I am gonna loop @balloob in though, because Coveralls is showing the same file (remote.py) decreased coverage, which is an issue I had a few days ago that he had to fix because of bad code he pushed.

@robbiet480 robbiet480 merged commit 630b737 into dev May 14, 2016
@balloob balloob deleted the improve_get_age branch May 14, 2016 19:12
@balloob
Copy link
Member

balloob commented May 14, 2016

It's all good except that you forgot the dolphin of approval! Coveralls should only report an error status when coverage decreased 0.5+%. Not sure what is going on there.

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants