Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a message when reconnected after a connection failure #20261

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

rytilahti
Copy link
Member

Description:

Print an informational message when a connection with the device has been re-established.

Required for IQS silver classification.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@rytilahti
Copy link
Member Author

Coverage seems to be failing even though there are no tests for this, so the problem must be elsewhere..

@balloob balloob merged commit e69ca81 into home-assistant:dev Jan 21, 2019
@ghost ghost removed the in progress label Jan 21, 2019
@rytilahti rytilahti deleted the songpal_report_reconnect branch January 21, 2019 13:14
@balloob balloob mentioned this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants