Skip to content

Embed mailgun platform into component #20147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2019
Merged

Embed mailgun platform into component #20147

merged 3 commits into from
Jan 16, 2019

Conversation

rohankapoorcom
Copy link
Member

@rohankapoorcom rohankapoorcom commented Jan 16, 2019 •
edited
Loading

Description:

This PR leverages #19948 to embed the Mailgun notify platform under the component.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Jan 16, 2019
@balloob balloob merged commit 48127ca into home-assistant:dev Jan 16, 2019
@ghost ghost removed the in progress label Jan 16, 2019
@rohankapoorcom rohankapoorcom deleted the embed-mailgun branch January 16, 2019 20:06
@balloob balloob mentioned this pull request Jan 23, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Feb 12, 2019
@rohankapoorcom @alandtse
Embed mailgun platform into component (home-assistant#20147)
b31a6e2 
* Embed mailgun platform into component

* home-assistant#20147: Update .coveragerc

* home-assistant#20147 update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed integration: mailgun small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohankapoorcom @balloob @homeassistant