Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPnP port mapping component #1790

Merged
merged 4 commits into from
Apr 11, 2016
Merged

UPnP port mapping component #1790

merged 4 commits into from
Apr 11, 2016

Conversation

robbiet480
Copy link
Member

Description: This adds a new UPnP component which will automagically port map your Home Assistant instance. It requires miniupnpc to be installed.

Example entry for configuration.yaml (if applicable):

upnp:

Checklist:

If code communicates with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

from homeassistant.const import (EVENT_HOMEASSISTANT_STOP)

DEPENDENCIES = ["api"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a REQUIREMENTS = for miniupnpc

@robbiet480 robbiet480 merged commit 5d8cd6d into home-assistant:dev Apr 11, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants