Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gstreamer-player to 1.1.2 #17568

Merged

Conversation

partofthething
Copy link
Contributor

@partofthething partofthething commented Oct 18, 2018

Description:

Bump dependency to solve cpu issue

Related issue (if applicable): fixes #7515

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @partofthething,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-needed small-pr PRs with less than 30 lines. labels Oct 18, 2018
@ghost ghost added the in progress label Oct 18, 2018
@balloob
Copy link
Member

balloob commented Oct 18, 2018

Liar liar pants on fire:

image

@partofthething
Copy link
Contributor Author

Yikes, sorry. Rusty. Should be better now.

@MartinHjelmare MartinHjelmare merged commit e343f55 into home-assistant:dev Oct 19, 2018
@ghost ghost removed the in progress label Oct 19, 2018
@balloob balloob mentioned this pull request Oct 26, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed Hacktoberfest small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gstreamer causing 100% cpu
5 participants