Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up MjpegCamera by removing unnused hass object in __init__ #16628

Merged
merged 1 commit into from
Sep 15, 2018
Merged

Clean up MjpegCamera by removing unnused hass object in __init__ #16628

merged 1 commit into from
Sep 15, 2018

Conversation

rohankapoorcom
Copy link
Member

@rohankapoorcom rohankapoorcom commented Sep 15, 2018 •
edited
Loading

Description:

Clean up the MjpegCamera component (and all subclasses) to not pass hass into the __init__ method since it is not used. This was noticed by @MartinHjelmare in #16527 (comment)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost added the in progress label Sep 15, 2018
Kane610
Kane610 approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

MartinHjelmare
MartinHjelmare approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 19514ea into home-assistant:dev Sep 15, 2018
@ghost ghost removed the in progress label Sep 15, 2018
@rohankapoorcom rohankapoorcom deleted the remove-hass-from-mjpegcamera branch September 15, 2018 17:22
@balloob balloob mentioned this pull request Sep 28, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kane610 Kane610 Kane610 approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: axis integration: mjpeg integration: zoneminder small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rohankapoorcom @MartinHjelmare @Kane610 @homeassistant