-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small huawei_lte improvements #16626
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Add bunch of RouterData tests
- Loading branch information
commit 0a80d1544f6afe3cf7ae2e761e3a9c11e43beb59
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
"""Huawei LTE component tests.""" | ||
import pytest | ||
|
||
from homeassistant.components import huawei_lte | ||
|
||
|
||
@pytest.fixture(autouse=True) | ||
def routerdata(): | ||
"""Set up a router data for testing.""" | ||
rd = huawei_lte.RouterData(None) | ||
rd.device_information = dict( | ||
SoftwareVersion="1.0", | ||
nested=dict(foo="bar"), | ||
) | ||
return rd | ||
|
||
|
||
async def test_routerdata_get_nonexistent_leaf(routerdata): | ||
"""Test that accessing a nonexistent leaf element raises KeyError.""" | ||
with pytest.raises(KeyError): | ||
routerdata["device_information.foo"] | ||
|
||
|
||
async def test_routerdata_get_nonexistent_leaf_path(routerdata): | ||
"""Test that accessing a nonexistent long path raises KeyError.""" | ||
with pytest.raises(KeyError): | ||
routerdata["device_information.long.path.foo"] | ||
|
||
|
||
async def test_routerdata_get_simple(routerdata): | ||
"""Test that accessing a short, simple path works.""" | ||
assert routerdata["device_information.SoftwareVersion"] == "1.0" | ||
|
||
|
||
async def test_routerdata_get_longer(routerdata): | ||
"""Test that accessing a longer path works.""" | ||
assert routerdata["device_information.nested.foo"] == "bar" | ||
|
||
|
||
async def test_routerdata_get_dict(routerdata): | ||
"""Test that returning an intermediate dict works.""" | ||
assert routerdata["device_information.nested"] == dict(foo="bar") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to use
{key: value}
to define a dictionary.