-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite bluetooth le #16592
Merged
Merged
Rewrite bluetooth le #16592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: device_tracker
core
small-pr
PRs with less than 30 lines.
labels
Sep 13, 2018
ghost
assigned pvizeli
Sep 13, 2018
ghost
added
the
in progress
label
Sep 13, 2018
houndci-bot
reviewed
Sep 13, 2018
result = mac in devs | ||
if not result: | ||
# Could not lookup device name | ||
for mac in devs_to_track: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
balloob
approved these changes
Sep 13, 2018
2 tasks
ghost
assigned balloob
Sep 14, 2018
ghost
removed
the
in progress
label
Sep 14, 2018
balloob
pushed a commit
that referenced
this pull request
Sep 15, 2018
* Rewrite bluetooth le * Update requirements_all.txt * Update gen_requirements_all.py * Update bluetooth_le_tracker.py * Update bluetooth_le_tracker.py * Update bluetooth_le_tracker.py * Update bluetooth_le_tracker.py * Update bluetooth_le_tracker.py * Update bluetooth_le_tracker.py
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The old python gattlib work not anymore with newer python version and make a lot of problems on RPi with performance. I see this code: https://community.home-assistant.io/t/ble-custom-component/48355
I rewrite some parts. I hope this platform will be work suitable after this update.
home-assistant/home-assistant.io#6273
Checklist:
tox
. Your PR cannot be merged unless tests passrequirements_all.txt
by running