Switchmate #16395
Merged
Switchmate #16395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned | return False | ||
| return True | ||
|
|
||
| def _sendpacket(self, key, retry=2) -> bool: |
There was a problem hiding this comment.
This is what we regularly ask to be in a standalone library.
There was a problem hiding this comment.
Ok, I thought it might be ok since it so few lines.
But I will make a standalone library.
added 2 commits
September 11, 2018 16:33
houndci-bot
reviewed
Sep 11, 2018
| mac_addr = config.get(CONF_MAC) | ||
| add_entities([Switchmate(mac_addr, name)], True) | ||
| mac_addr = config[CONF_MAC] | ||
| add_devices([Switchmate(mac_addr, name)], True) |
|
I am not finished testing this locally |
|
|
||
| @property | ||
| def unique_id(self) -> str: | ||
| """Return a unique, HASS-friendly identifier for this entity.""" | ||
| return self._mac.replace(':', '') | ||
| return '{0}'.format(self._mac.replace(':', '')) |
There was a problem hiding this comment.
String formatting doesn't seem to be needed.
|
This works fine locally. |
MartinHjelmare
approved these changes
Sep 12, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make switchmate a bit more robust
Checklist:
tox. Your PR cannot be merged unless tests pass