Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and restore context in recorder [MIGRATION] #15859

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Aug 6, 2018

Description:

This stores context in the database and restores it when being retrieved.

This requires a migration and might take long. I added a new migration step "add columns". For MySql it will try to add all columns at once, for SQLite it will need to do 1 at a time.

CC @OverloadUT

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner August 6, 2018 11:18
@ghost ghost assigned balloob Aug 6, 2018
@ghost ghost added the in progress label Aug 6, 2018
@balloob balloob changed the title Add and restore context in recorder Add and restore context in recorder [MIGRATION] Aug 6, 2018
@balloob balloob merged commit 9512bb9 into dev Aug 10, 2018
@balloob balloob deleted the context-recorder branch August 10, 2018 16:09
@ghost ghost removed the in progress label Aug 10, 2018
@balloob balloob mentioned this pull request Aug 17, 2018
@randellhodges
Copy link
Contributor

The add columns method fails against MSSQL. The word "COLUMN" breaks it. Probably needs a workaround like the drop_index method uses.

See here for the post I created over on the home assistant community.

@dashony
Copy link

dashony commented Aug 21, 2018

hi guys, not sure if it is to do with this add-on but since I've upgraded to v0.76 I'm getting "invalid config" ,. I have not made any changes to these 3 features. (using HASS.io on Pi2)
image

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants