Skip to content

Conversation

@flip-dots
Copy link
Contributor

@flip-dots flip-dots commented Dec 7, 2025

Proposed change

This updates the hue_ble component to work with the latest version of HueBLE. Quite a few issues have been raised and the existing logging functionality in the library was not quite as good as I thought it was, so I updated the underlying library with better logging and also made some changes which should improve compadability with other lights.

#158157
#158030

Library diff
Library changelog

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@joostlek
Copy link
Member

joostlek commented Dec 8, 2025

Kind reminder to send me a message on Discord :)

@home-assistant home-assistant bot marked this pull request as draft December 8, 2025 14:25
@home-assistant
Copy link

home-assistant bot commented Dec 8, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@flip-dots flip-dots marked this pull request as ready for review December 8, 2025 15:23
@home-assistant home-assistant bot requested a review from joostlek December 8, 2025 15:23
Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More specific as in, we shouldn't catch bare exceptions

@home-assistant home-assistant bot marked this pull request as draft December 8, 2025 15:37
@flip-dots flip-dots marked this pull request as ready for review December 8, 2025 17:58
@home-assistant home-assistant bot requested a review from joostlek December 8, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants