-
-
Notifications
You must be signed in to change notification settings - Fork 36k
Add target_humidity_step attribute to humidifier #156906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add target_humidity_step attribute to humidifier #156906
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
81c4c9c to
4188330
Compare
4188330 to
25a4e77
Compare
frenck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hi there @LG-ThinQ-Integration 👋
Thanks for opening a pull request. However, this PR changes a core base entity component. Changes to these require an architectural discussion which has been approved.
I wasn't able to locate the architectural proposal for this one, can you please point me to it?
Thanks! 👍
../Frenck
Blogging my personal ramblings at frenck.dev
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
@frenck |
Proposed change
Add attribute "target_humidity_step" to humidifier for customize step in frontend.
It was discussed that this attribute is necessary to apply LG-based humidifiers. #152593 (comment)
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: