Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide sms notifications via messagebird #1553

Merged
merged 2 commits into from
Mar 18, 2016
Merged

provide sms notifications via messagebird #1553

merged 2 commits into from
Mar 18, 2016

Conversation

florianholzapfel
Copy link
Contributor

Description:
This PR provides a notification plugin for MessageBird (https://www.messagebird.com), a SMS gateway.

Related issue (if applicable): #

Example entry for configuration.yaml (if applicable):

Checklist:

  • Local tests with tox run successfully.
  • TravisCI does not fail. Your PR cannot be merged unless CI is green!
  • Fork is up to date and was rebased on the dev branch before creating the PR.
  • Commits have been squashed.
  • If code communicates with devices:
    • New dependencies have been added to the REQUIREMENTS variable (example).
    • New dependencies are only imported inside functions that use them (example).
    • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
    • New files were added to .coveragerc.
  • If the code does not interact with devices:
    • Tests have been added to verify that the new code works.


if CONF_API_KEY not in config:
_LOGGER.error("Unable to find config key '%s'", CONF_API_KEY)
return None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use validate_config here to check the presence of required entries.

balloob added a commit that referenced this pull request Mar 18, 2016
provide sms notifications via messagebird
@balloob balloob merged commit 302f32e into home-assistant:dev Mar 18, 2016
@balloob
Copy link
Member

balloob commented Mar 18, 2016

Perect. 🐬

@florianholzapfel florianholzapfel deleted the notify-messagebird branch March 20, 2016 16:19
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants