Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Wemo startup race condition. #1542

Merged
merged 1 commit into from
Mar 14, 2016
Merged

Handle Wemo startup race condition. #1542

merged 1 commit into from
Mar 14, 2016

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented Mar 14, 2016

Description:
I've just started to see some errors on startup of WeMo switches.

This can result in not setting initial state - and the devices being unavailable.

Suspect this is a race condition where the callback from the wemo comes back before the HA component is initialized. I guess this could be because of other HA changes have changed the timing on startup.

This PR copes with getting initial state correct - even if the HA component isn't initialized.

Checklist:

  • Local tests with tox run successfully.
  • TravisCI does not fail. Your PR cannot be merged unless CI is green!
  • Fork is up to date and was rebased on the dev branch before creating the PR.
  • Commits have been squashed.
    script/gen_requirements_all.py.
    • New files were added to .coveragerc.
  • If the code does not interact with devices:
    • Tests have been added to verify that the new code works.

balloob added a commit that referenced this pull request Mar 14, 2016
Handle Wemo startup race condition.
@balloob balloob merged commit 3e3d1ae into dev Mar 14, 2016
@balloob balloob deleted the fix_race_condition branch March 14, 2016 14:47
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants