Tado refactor to tadoasync & API changes #151933

erwindouna · 2025-09-08T18:51:17Z

Breaking change

This PR is meant as a general refactor to make the API calls more efficient by utilizing the asynchronous principles. This means that there's a switch from PyTado to tadoasync. The is a work in progress PR. please treat it as such.

Main parts to benefit from this PR:

Asynchronous library, doing all the heavy-lifting to the Tado REST API.
Better session handler (next attempt to tackle the long awaited re-authentication issues users experience).
Efficient usage of the Tado's API (remove redundant calls, etc.)

Proposed change

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

MrEbbinghaus · 2025-09-11T09:32:24Z

@erwindouna Seeing that large of a refactor.
Have you looked at Home Assistant's built-in OAuth support?

https://developers.home-assistant.io/docs/config_entries_config_flow_handler#configuration-via-oauth2

erwindouna · 2025-09-11T09:34:57Z

@erwindouna Seeing that large of a refactor.
Have you looked at Home Assistant's built-in OAuth support?

https://developers.home-assistant.io/docs/config_entries_config_flow_handler#configuration-via-oauth2

I did indeed. That particular parts of HA only supports client credentials, not the device authentication Tado has put on. That explains the extra work both in python-tado and the Tado integration I programmed. :)

MrEbbinghaus · 2025-09-11T11:46:57Z

@erwindouna I see. I thought there might be a way to implement the device flow as a custom solution, but the API seems to be very focused on client credentials.

Copilot

Pull Request Overview

This PR refactors the Tado integration from the synchronous PyTado library to the asynchronous tadoasync library, aimed at improving efficiency and addressing authentication issues users experience with the current implementation.

Key changes:

Library Migration: Switches from python-tado (PyTado) to tadoasync for better async support
API Restructure: Updates data models and API calls to use the new library's structured data classes
Test Modernization: Refactors test files to use new mock structures and removes deprecated testing patterns

Reviewed Changes

Copilot reviewed 34 out of 34 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`homeassistant/components/tado/manifest.json`	Updates dependency from `python-tado==0.18.15` to `tadoasync==0.2.2`
`homeassistant/components/tado/coordinator.py`	Major refactor to use tadoasync models and async patterns instead of PyTado
`homeassistant/components/tado/climate.py`	Updates to work with new data structures from tadoasync library
`homeassistant/components/tado/config_flow.py`	Refactors authentication flow to use async device activation
`tests/components/tado/conftest.py`	Updates test fixtures to mock the new tadoasync API
Various test files	Modernizes test patterns and removes deprecated utility functions

Copilot · 2025-09-24T20:40:54Z

homeassistant/components/tado/switch.py

-
-        if not zoneChildLockSupported:
+    for zone in tado.zones.values():
+        if not len(zone.devices) > 0 and zone.devices[0].child_lock_enabled is not None:


Logic error in the condition. The current condition if not len(zone.devices) > 0 and zone.devices[0].child_lock_enabled is not None: will cause an IndexError when zone.devices is empty because it tries to access zone.devices[0] even when the list is empty. The condition should be if len(zone.devices) > 0 and zone.devices[0].child_lock_enabled is not None: (removing the not).

Suggested change

if not len(zone.devices) > 0 and zone.devices[0].child_lock_enabled is not None:

if len(zone.devices) == 0 or zone.devices[0].child_lock_enabled is None:

Copilot · 2025-09-24T20:40:55Z

tests/components/tado/test_helper.py

+from tadoasync import Tado



Unused import. The Tado class is imported but not used in this test file. Consider removing this import to keep the code clean.

Suggested change

from tadoasync import Tado

Copilot · 2025-09-24T20:40:55Z

homeassistant/components/tado/climate.py

+    # This is on older interface style, where the temperatures are inside the HEATING data attribute
+    # TODO: see if this still relevant, whereas it will most likely always resolve in the second if-statement
+    # if capabilities.type == CONST_MODE_HEAT and capabilities[CONST_MODE_HEAT].get(
+    #     "temperatures"
+    # ):
+    #     heat_temperatures = capabilities[CONST_MODE_HEAT]["temperatures"]
+    # CHECK WITH A TADO DEV



Large block of commented-out code with TODO comments should be resolved. Either implement the proper logic for handling older interface styles or remove the commented code if it's no longer needed. The comment 'CHECK WITH A TADO DEV' suggests this needs developer input before the refactor is complete.

Suggested change

# This is on older interface style, where the temperatures are inside the HEATING data attribute

# TODO: see if this still relevant, whereas it will most likely always resolve in the second if-statement

# if capabilities.type == CONST_MODE_HEAT and capabilities[CONST_MODE_HEAT].get(

# "temperatures"

# ):

# heat_temperatures = capabilities[CONST_MODE_HEAT]["temperatures"]

# CHECK WITH A TADO DEV

Copilot · 2025-09-24T20:40:55Z

homeassistant/components/tado/sensor.py

+    # if "presenceLocked" in data:
+    if data.presence_locked:
        geofencing_switch_mode = "manual"
+    else:
+        geofencing_switch_mode = "auto"
+    # else:
+    #     geofencing_switch_mode = "manual"


Commented-out code should be removed. The old dictionary-style access pattern is no longer needed since the function now receives a structured HomeState object. Clean up by removing the commented lines.

frenck

Whoa @erwindouna 🤯

That is quite a large PR. I would strongly recommend into making smaller iterations.

That said, there are CI failure, so marking this PR a draft.

erwindouna · 2025-10-19T20:55:41Z

Fair point, @frenck - quite a lot of work went into this and it’s still in progress. The challenge is that this PR both switches from PyTado to tadoasync and converts the integration from synchronous to asynchronous. I haven’t found a clean way to split that up without breaking the existing integration in between, since we can’t run both libraries side-by-side.

Do you have a suggestion on how you’d like this divided? I’d be happy to adjust the approach if there’s a preferred pattern for handling this kind of library migration. Once this migration is done, I intend to optimize the integration to handle the API interactions as efficient as possible. So it that sense I already intended to split up PR's. 🙈

jwt99412 · 2025-11-23T13:32:54Z

Any update on this? Keen to test.

ArtemKiyashko · 2026-01-19T13:55:23Z

This I become critical since tado dramatically decreased limit rate on their API :)

banter240 · 2026-01-19T14:00:05Z

Tbh I doubt that this will change anything. 100 API calls is good for nothing.

I build a "companion" for HomeKit and in the future for matter, to add the missing pieces like battery entities, home/away toggle, schedule toggle etc. Feel free to ask for even more. With it you can also see the current API Quota.

https://github.com/banter240/tado_hijack/

ArtemKiyashko · 2026-01-21T21:31:01Z

@frenck hey, could you respond to @erwindouna ?

without that change tado integration completely useless.
@erwindouna what if introduce separate integration temporary for beta testing? Name it like „Tado async” and push separately. For example. Then current integration become „stable” for safety and give you space for bugfixes of beta-integration.

Thanks, gents. We really waiting that :)

erwindouna added 2 commits September 8, 2025 18:01

Change library to tadoasync

d7c64c2

Refactor the login flow

4d5407f

home-assistant bot added cla-signed code-quality has-tests integration: tado new-feature by-code-owner Quality Scale: No score labels Sep 8, 2025

erwindouna mentioned this pull request Sep 8, 2025

Tado forget the authentication #142169

Open

erwindouna added 2 commits September 8, 2025 22:58

Merge branch 'dev' into tado

2491454

Current progress

a83514f

erwindouna mentioned this pull request Sep 10, 2025

Upcoming changes to the tado° API #151223

Open

karlbeecken mentioned this pull request Sep 10, 2025

Tado X support (again) erwindouna/python-tado#112

Open

erwindouna added 6 commits September 14, 2025 19:14

Merge branch 'dev' into tado

5b53d59

Current progress on tests refactor

e7a4087

Current progress

21d6746

Current progress

e0071b8

Current progress

71b765b

Working tests

609f038

erwindouna marked this pull request as ready for review September 24, 2025 20:39

Copilot AI review requested due to automatic review settings September 24, 2025 20:39

Merge branch 'dev' into tado

6187146

Copilot AI reviewed Sep 24, 2025

View reviewed changes

frenck reviewed Oct 18, 2025

View reviewed changes

frenck marked this pull request as draft October 18, 2025 20:48

erwindouna mentioned this pull request Oct 27, 2025

Add Tado heating circuit select with own coordinator for reduced number of API-calls #150268

Draft

19 tasks

erwindouna mentioned this pull request Nov 3, 2025

Python-tado library not maintained anymore #155730

Open

erwindouna mentioned this pull request Jan 11, 2026

Tado Authentication Broken after update to 2026.01 HA Core update #160472

Open

	if not len(zone.devices) > 0 and zone.devices[0].child_lock_enabled is not None:
	if len(zone.devices) == 0 or zone.devices[0].child_lock_enabled is None:

Uh oh!

Tado refactor to tadoasync & API changes #151933

Are you sure you want to change the base?

Tado refactor to tadoasync & API changes #151933

Uh oh!

Conversation

erwindouna commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Breaking change

Proposed change

Type of change

Additional information

Checklist

Uh oh!

MrEbbinghaus commented Sep 11, 2025

Uh oh!

erwindouna commented Sep 11, 2025

Uh oh!

MrEbbinghaus commented Sep 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

frenck left a comment

Choose a reason for hiding this comment

Uh oh!

erwindouna commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jwt99412 commented Nov 23, 2025

Uh oh!

ArtemKiyashko commented Jan 19, 2026

Uh oh!

banter240 commented Jan 19, 2026

Uh oh!

ArtemKiyashko commented Jan 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erwindouna commented Sep 8, 2025 •

edited

Loading

erwindouna commented Oct 19, 2025 •

edited

Loading