-
-
Notifications
You must be signed in to change notification settings - Fork 36.6k
Adjust urllib3 constraint #145485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust urllib3 constraint #145485
Conversation
97463d1 to
d1ec0d4
Compare
d1ec0d4 to
bbe5553
Compare
| typing-extensions>=4.14.0,<5.0 | ||
| ulid-transform==1.4.0 | ||
| urllib3>=1.26.5,<2 | ||
| urllib3>=1.26.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the constraint to >=2.0 or even something newer like 2.2 or 2.4? That way we could prevent accidentally installing an old version again.
Note that it might cause issues with custom components but maybe the best way to deal with those would be to see what breaks after the release and fix the dependencies then accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe >=2.0 is a good first step - so users have time to spot the deprecation warnings and adjust accordingly.
d903299 to
20fc69b
Compare
cdce8p
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @epenet for your work getting this to the finish line 🚀
Proposed change
urllib3 v2 was released in early 2023
https://urllib3.readthedocs.io/en/stable/v2-migration-guide.html
Needs:
Original issue #97248 was linked to botocore which has since been made compatible with urllib3 v2
See in particular boto/botocore@785d224 (enable
<2.1) and boto/botocore#3141 (enable<3)Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: