Bring back typing check. Meanwhile just for homeassistant/*.py #14410
Conversation
| return func | ||
|
|
||
|
|
||
| def is_callback(func: Callable[..., Any]) -> bool: | ||
| """Check if function is safe to be called in the event loop.""" | ||
| return '_hass_callback' in getattr(func, '__dict__', {}) | ||
| return getattr(func, '_hass_callback', False) is True |
There was a problem hiding this comment.
The is True shouldn't be needed. We will return a boolean anyway.
There was a problem hiding this comment.
Well, since the value could theoretically be anything, I think it's ok to check.
There was a problem hiding this comment.
Specifically in tests it is MagicMock
tox.ini
Outdated
| deps = | ||
| -r{toxinidir}/requirements_test.txt | ||
| commands = | ||
| mypy --ignore-missing-imports --follow-imports=skip homeassistant | ||
| /bin/bash -c 'mypy --ignore-missing-imports --follow-imports=skip homeassistant/*.py' |
There was a problem hiding this comment.
The mypy docs recommend using silent instead of skip.
http://mypy.readthedocs.io/en/latest/command_line.html#follow-imports
There was a problem hiding this comment.
When I run with silent there's one additional error in bootstrap on line 301.
|
Nice! I was talking to Instagram here at PyCon. They have released MonkeyType. It will run your test suite and then suggest types for your code. And then FB also published Pyre, a fast type checker. We should compare performance against mypy. |
andrey-git
changed the title
Pyre is designed to remember the result and state of the code and will normally only check changed code. If I run without forcing a recheck it takes less than a second to run again since nothing has changed. The output is not the same as for mypy though. I get lots of these errors when running pyre: |
Description:
Bring back typing check.
Meanwhile just for
homeassistant/*.py, rest of core to follow.Checklist:
tox. Your PR cannot be merged unless tests pass