Give unknown zwave nodes a better name #14353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
cla-signed
integration: zwave
small-pr
balloob
approved these changes
May 29, 2018
|
Is this common? |
|
Probably rare. I have such phanthom node (I'm even not sure if that is a real device or a ozw bug) |
Merged
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Give unknown zwave nodes a better name * Update util.py
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If zwave node couldn't be parsed for manufacturer/product and also wasn't given a saved-in-zwave
nameit would get a" "name and"_"ID.This PR would result in
"Unknown Node <node_id>"name instead.This is a breaking change as such node won't be in the entity registry and thus the entity_id would change.
Checklist:
tox. Your PR cannot be merged unless tests pass