Skip to content

Conversation

Shutgun
Copy link
Contributor

@Shutgun Shutgun commented Apr 14, 2025

Proposed change

Bump devolo_plc_api to 1.5.1. It introduced the SPDX license identifier and a retry mechanism to hopefully reduce the probability to see #134805.

However, there is a sub-dependency conflict with linear-garage-door that I don't know how to resolve easily. linear-garage-door depends on tenacity<9.0.0 while I not being aware of that constraint only tested with tenacity>=9.0.0. Linear Garage Door is marked for removal in 2025.8.0 and has 0 users according to analytics. Please advice how to handle this.

Changelog: https://github.com/2Fake/devolo_plc_api/releases/tag/v1.5.0, https://github.com/2Fake/devolo_plc_api/releases/tag/v1.5.1
Git diff: 2Fake/devolo_plc_api@v1.4.1...v1.5.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @2Fake, mind taking a look at this pull request as it has been labeled with an integration (devolo_home_network) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of devolo_home_network can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign devolo_home_network Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey hey @Shutgun 👋

The CI seems to be failing. Could you place take a look?

Thanks 👍

../Frenck

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft April 14, 2025 09:43
@Shutgun
Copy link
Contributor Author

Shutgun commented Apr 14, 2025

Hi @frenck , that's because of the sub-dependency conflict that I described in the summary and asked for advice. Can you help me?

@frenck
Copy link
Member

frenck commented Apr 14, 2025

Well, in the case of conflicts, you either need to solve the conflict on your end or fix the other end.

../Frenck

@Shutgun
Copy link
Contributor Author

Shutgun commented Apr 14, 2025

ok...

Since the other end is dead, without usage and marked for removal already, I'd hoped there is a different solution. I will work through the release notes of tenacity and check if I can work with older version.

@Shutgun Shutgun changed the title Bump devolo_plc_api to 1.5.0 Bump devolo_plc_api to 1.5.1 Apr 14, 2025
@Shutgun Shutgun marked this pull request as ready for review April 14, 2025 19:11
@home-assistant home-assistant bot requested a review from frenck April 14, 2025 19:11
@frenck frenck added this to the 2025.4.3 milestone Apr 14, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Shutgun 👍

../Frenck

@frenck frenck merged commit a772832 into home-assistant:dev Apr 14, 2025
48 checks passed
@Shutgun Shutgun deleted the bump_hn branch April 14, 2025 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Develo] - Error fetching last_restart data
2 participants