-
-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Select correct Reolink device uid #142864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since the code was non-obvious enough to need a fix, this seems like a case that really deserves a test. Let's make sure one is added before the PR moves forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, what bdraco said
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Breaking change
Proposed change
When connecting a camera both through a NVR/Home Hub and directly, the
get_device_uid_and_ch
function could select the wrong device UID causing problems.This PR ensures the correct UID is selected.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: