Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take exclude vias in unique ids for nmbs #136590

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Jan 26, 2025

Proposed change

Addressing #121548 (comment). Some users may want to prefer a direct connection with no stops in between and may thus setup 2 config flows between 2 stations whereof one is excluding vias and another one including vias.

I'm hoping this can land in the beta, since I'm changing unique ids that were initially introduced (or were migrated) in this version 2025.2.0.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@silamon silamon changed the title Take exclude vias in unique ids Take exclude vias in unique ids for nmbs Jan 26, 2025
@joostlek joostlek merged commit d9deba3 into home-assistant:dev Jan 29, 2025
32 checks passed
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Jan 29, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants