Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy-dev to 1.16.0a1 #136544

Merged
merged 3 commits into from
Jan 26, 2025

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 25, 2025

Proposed change

https://github.com/cdce8p/mypy-dev/releases/tag/1.15.0a2
https://github.com/cdce8p/mypy-dev/releases/tag/1.16.0a1
Compare: python/mypy@5e119d0...1eb9d4c

  • Typeshed updates
  • Misc bugfixes
  • Added support for properties with different getter and setter types

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner January 25, 2025 22:31
@home-assistant
Copy link

Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration (flux_led) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of flux_led can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign flux_led Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Jan 25, 2025
Comment on lines 302 to 303
bulb.discovery = discovery
if discovery is not None:
bulb.discovery = discovery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to the dependency bump?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upstream library expects a not None object for the discovery setter. Even though it internally handles None as well.

Opened lightinglibs/flux_led#405 upstream to correct that.

@cdce8p cdce8p removed the smash Indicator this PR is close to finish for merging or closing label Jan 26, 2025
@cdce8p cdce8p added the smash Indicator this PR is close to finish for merging or closing label Jan 26, 2025
@andrewsayre andrewsayre merged commit 107184b into home-assistant:dev Jan 26, 2025
46 checks passed
@cdce8p cdce8p deleted the update-mypy-dev-1.16.0a1 branch January 26, 2025 23:47
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed dependency integration: flux_led Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants