-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mypy-dev to 1.16.0a1 #136544
Update mypy-dev to 1.16.0a1 #136544
Conversation
Hey there @icemanch, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bulb.discovery = discovery | ||
if discovery is not None: | ||
bulb.discovery = discovery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this related to the dependency bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The upstream library expects a not None
object for the discovery
setter. Even though it internally handles None
as well.
Opened lightinglibs/flux_led#405 upstream to correct that.
Proposed change
https://github.com/cdce8p/mypy-dev/releases/tag/1.15.0a2
https://github.com/cdce8p/mypy-dev/releases/tag/1.16.0a1
Compare: python/mypy@5e119d0...1eb9d4c
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: