Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for permission to disable Reolink privacy mode during config flow #136511

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

Reolink recently added a "Privacy mode" to the firmware of the Reolink E1 Zoom.
When the user activates this mode, the camera streams, HTTP API, ONVIF, RTMP, RTSP ports are all shut down.
Basically the only two things the camera can do at this point is disabling the privacy mode or rebooting (only options left in the Reolink app also).

During config flow setup, we need to retrieve the information from the reolink device, therefore it is not possible to have privacy mode turned on during config flow.

This PR will detect when privacy mode is turned ON and if so, ask the user for permission to disable it. Once disabled the config flow will continue as usual. when the setup is complete, the user is free to enable privacy mode again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG mentioned this pull request Jan 25, 2025
19 tasks
@starkillerOG
Copy link
Contributor Author

@zweckj thanks for the review!

@starkillerOG starkillerOG merged commit f1dfae6 into home-assistant:dev Jan 27, 2025
32 checks passed
@starkillerOG starkillerOG deleted the reolink_privacy_config branch January 27, 2025 09:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants