Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix descriptions of send_command action for consistency #135670

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

NoRi2909
Copy link
Contributor

Proposed change

Three small fixes for the description keys of the send_command action of the Homeworks integration:

  • use third-person singular for descriptive wording
  • change to "the command" to match "the controller" in two strings

Both ensure better and more consistent machine and human translations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Three small fixes for the description keys of the send_command action of the Homeworks integration:
- use third-person singular for descriptive wording
- Change to "the command" to match "the controller" in two strings

Both ensure better and more consistent machine and human translations.
@thecode thecode merged commit 9c5c1a3 into home-assistant:dev Jan 15, 2025
32 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
@NoRi2909 NoRi2909 deleted the patch-551166 branch February 7, 2025 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants