-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call async_forward_setup_entry after the first refresh in SwitchBot Cloud #135625
Call async_forward_setup_entry after the first refresh in SwitchBot Cloud #135625
Conversation
Hey there @SeraphicRav, @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
2a039c9
to
f54d929
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
f54d929
to
ca9b086
Compare
ca9b086
to
3004c08
Compare
3004c08
to
667931e
Compare
667931e
to
c09b722
Compare
c09b722
to
9ec92e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
Currently the first refresh of the SwitchBot Cloud coordinators is done after
async_forward_setup_entry
, preventing the devices' status from being used during setup.This PR switches the order to refresh first.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: