Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call async_forward_setup_entry after the first refresh in SwitchBot Cloud #135625

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

mckbrmn
Copy link
Contributor

@mckbrmn mckbrmn commented Jan 14, 2025

Proposed change

Currently the first refresh of the SwitchBot Cloud coordinators is done after async_forward_setup_entry, preventing the devices' status from being used during setup.
This PR switches the order to refresh first.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @SeraphicRav, @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration (switchbot_cloud) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot_cloud can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot_cloud Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mckbrmn mckbrmn force-pushed the switchbot-cloud-first-refresh branch from 2a039c9 to f54d929 Compare January 14, 2025 22:35
homeassistant/components/switchbot_cloud/entity.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 14, 2025 22:56
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mckbrmn mckbrmn force-pushed the switchbot-cloud-first-refresh branch from f54d929 to ca9b086 Compare January 15, 2025 09:28
@mckbrmn mckbrmn marked this pull request as ready for review January 15, 2025 09:31
@home-assistant home-assistant bot requested a review from joostlek January 15, 2025 09:31
@mckbrmn mckbrmn force-pushed the switchbot-cloud-first-refresh branch from ca9b086 to 3004c08 Compare January 15, 2025 09:31
@home-assistant home-assistant bot marked this pull request as draft January 15, 2025 11:19
@abmantis abmantis changed the title SwitchBot Cloud: async_forward_setup_entry should be called after the first refresh Call async_forward_setup_entry after the first refresh in SwitchBot Cloud Jan 15, 2025
@mckbrmn mckbrmn force-pushed the switchbot-cloud-first-refresh branch from 3004c08 to 667931e Compare January 15, 2025 11:28
@mckbrmn mckbrmn marked this pull request as ready for review January 15, 2025 11:29
@home-assistant home-assistant bot requested a review from abmantis January 15, 2025 11:29
@home-assistant home-assistant bot marked this pull request as draft January 15, 2025 11:42
@mckbrmn mckbrmn force-pushed the switchbot-cloud-first-refresh branch from 667931e to c09b722 Compare January 15, 2025 11:49
@mckbrmn mckbrmn marked this pull request as ready for review January 15, 2025 11:50
@home-assistant home-assistant bot requested a review from abmantis January 15, 2025 11:50
@mckbrmn mckbrmn force-pushed the switchbot-cloud-first-refresh branch from c09b722 to 9ec92e3 Compare January 15, 2025 12:42
Copy link
Contributor

@abmantis abmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abmantis abmantis dismissed joostlek’s stale review January 15, 2025 14:23

Suggestions addressed

@abmantis abmantis merged commit 6a50648 into home-assistant:dev Jan 15, 2025
28 checks passed
@mckbrmn mckbrmn deleted the switchbot-cloud-first-refresh branch January 15, 2025 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants