Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register Airzone WebServer device #135538

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Jan 13, 2025

Proposed change

WebServer device doesn't get registered when connected via Ethernet because no sensors are created for the WiFi.
Only add WebServer to "via_device" on HotWater and System devices if there's WebServer data available from the API.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

WebServer device doesn't get registered when connected via Ethernet because no
sensors are created for the WiFi.
Only add WebServer to "via_device" on HotWater and System devices if there's
WebServer data available from the API.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@Noltari Noltari changed the title airzone: register WebServer device Register Airzone WebServer device Jan 13, 2025
@joostlek joostlek merged commit ca34541 into home-assistant:dev Jan 13, 2025
34 checks passed
@Noltari Noltari deleted the airzone-webserver-device-fixes branch January 13, 2025 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airzone Breaking config issues.
2 participants