Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensors for inventory items to Habitica #135331

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Jan 10, 2025

Proposed change

Adds 4 sensors displaying the amount of items in the inventory.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@tr4nt0r tr4nt0r force-pushed the habitica_inventory_sensors branch from 8dce45c to 7ec4781 Compare January 10, 2025 23:25
@NoRi2909

This comment was marked as resolved.

@tr4nt0r
Copy link
Contributor Author

tr4nt0r commented Jan 11, 2025

@NoRi2909 that's unrelated to this PR, that would have to be done in a separate PR. You can open a PR yourself if you don't mind...

@NoRi2909
Copy link
Contributor

No problem, PR coming in a few minutes …

@zweckj zweckj merged commit 0d85f54 into home-assistant:dev Jan 11, 2025
34 checks passed
@tr4nt0r tr4nt0r deleted the habitica_inventory_sensors branch January 11, 2025 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants